Changeset 4a3f767d in vaadin

Timestamp:

03/14/12 14:00:53 (14 months ago)

Author:

Artur Signell <artur@…>

Branches:

master, 7.0, 7.1

Children:

07c94092

Parents:

f38942e0

git-author:

Artur Signell <artur@…> (03/13/12 18:39:00)

git-committer:

Artur Signell <artur@…> (03/14/12 14:00:53)

Message:

Made TabSheet work again and removed TabSheet tab caching for now

Location:

src/com/vaadin

Files:

• terminal/gwt/client/ui/TabsheetBaseConnector.java (modified) (4 diffs)
• terminal/gwt/client/ui/VTabsheet.java (modified) (1 diff)
• terminal/gwt/server/AbstractCommunicationManager.java (modified) (2 diffs)
• ui/AbstractComponent.java (modified) (2 diffs)
• ui/TabSheet.java (modified) (8 diffs)

src/com/vaadin/terminal/gwt/client/ui/TabsheetBaseConnector.java

@@ -10 +10 @@
 import com.vaadin.terminal.gwt.client.ApplicationConnection;
 import com.vaadin.terminal.gwt.client.ComponentConnector;
-import com.vaadin.terminal.gwt.client.ConnectorMap;
 import com.vaadin.terminal.gwt.client.UIDL;
 
@@ -38 +37 @@
         final UIDL tabs = uidl.getChildUIDL(0);
 
-        // Paintables in the TabSheet before update
+        // Widgets in the TabSheet before update
         ArrayList<Widget> oldWidgets = new ArrayList<Widget>();
         for (Iterator<Widget> iterator = getWidget().getWidgetIterator(); iterator
@@ -76 +75 @@
         for (int i = 0; i < getWidget().getTabCount(); i++) {
             ComponentConnector p = getWidget().getTab(i);
-            // During the initial rendering the paintable might be null (this is
-            // weird...)
+            // null for PlaceHolder widgets
             if (p != null) {
                 oldWidgets.remove(p.getWidget());
@@ -83 +81 @@
         }
 
-        // Perform unregister for any paintables removed during update
+        // Detach any old tab widget, should be max 1
         for (Iterator<Widget> iterator = oldWidgets.iterator(); iterator
                 .hasNext();) {
             Widget oldWidget = iterator.next();
-            ComponentConnector oldPaintable = ConnectorMap.get(client)
-                    .getConnector(oldWidget);
             if (oldWidget.isAttached()) {
                 oldWidget.removeFromParent();
             }
-            ConnectorMap.get(client).unregisterConnector(oldPaintable);
         }
 

src/com/vaadin/terminal/gwt/client/ui/VTabsheet.java

@@ -897 +897 @@
     private void renderContent(final UIDL contentUIDL) {
         final ComponentConnector content = client.getPaintable(contentUIDL);
+        Widget newWidget = content.getWidget();
         if (tp.getWidgetCount() > activeTabIndex) {
             Widget old = tp.getWidget(activeTabIndex);
-            if (old != content) {
+            if (old != newWidget) {
                 tp.remove(activeTabIndex);
                 ConnectorMap paintableMap = ConnectorMap.get(client);

src/com/vaadin/terminal/gwt/server/AbstractCommunicationManager.java

@@ -952 +952 @@
 
                     for (Component child : getChildComponents(parent)) {
-                        if (child.getState().isVisible()
-                                && parent.isComponentVisible(child)) {
+                        if (child.isVisible()) {
                             String childConnectorId = getPaintableId(child);
                             children.put(childConnectorId);
@@ -963 +962 @@
                         throw new PaintException(
                                 "Failed to send hierarchy information about "
-                                        + parentConnectorId + " to the client: "
-                                        + e.getMessage());
+                                        + parentConnectorId
+                                        + " to the client: " + e.getMessage());
                     }
                 }

src/com/vaadin/ui/AbstractComponent.java

@@ -410 +410 @@
      */
     public boolean isVisible() {
-        return getState().isVisible()
-                && (getParent() == null || getParent().isVisible());
+        if (getParent() == null) {
+            return getState().isVisible();
+        } else {
+            return getState().isVisible() && getParent().isVisible()
+                    && ((HasComponents) getParent()).isComponentVisible(this);
+        }
     }
 
@@ -1700 +1704 @@
         }
     }
+
+    public String getConnectorId() {
+        throw new RuntimeException(
+                "TODO: Move connector id handling to AbstractComponent");
+    }
 }

src/com/vaadin/ui/TabSheet.java

@@ -8 +8 @@
 import java.lang.reflect.Method;
 import java.util.ArrayList;
-import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
-import java.util.HashSet;
 import java.util.Iterator;
 import java.util.Map;
@@ -29 +27 @@
 import com.vaadin.terminal.gwt.client.ui.TabsheetConnector;
 import com.vaadin.terminal.gwt.client.ui.VTabsheet;
-import com.vaadin.terminal.gwt.server.CommunicationManager;
 import com.vaadin.ui.Component.Focusable;
 import com.vaadin.ui.themes.Reindeer;
@@ -96 +93 @@
 
     /**
-     * Tabs that have been shown to the user (have been painted as selected).
-     */
-    private HashSet<Component> paintedTabs = new HashSet<Component>();
-
-    /**
      * Handler to be called when a tab is closed.
      */
@@ -381 +373 @@
         target.startTag("tabs");
 
-        Collection<Component> orphaned = new HashSet<Component>(paintedTabs);
-
         for (final Iterator<Component> i = getComponentIterator(); i.hasNext();) {
             final Component component = i.next();
-
-            orphaned.remove(component);
 
             Tab tab = tabs.get(component);
@@ -437 +425 @@
             if (component.equals(selected)) {
                 target.addAttribute("selected", true);
-                if (!paintedTabs.contains(component)) {
-                    // Ensure the component is painted if it hasn't already been
-                    // painted in this tabsheet
-                    component.requestRepaint();
-                    paintedTabs.add(component);
-                }
                 component.paint(target);
-            } else if (paintedTabs.contains(component)) {
-                component.paint(target);
-            } else {
-                component.requestRepaintRequests();
             }
             target.endTag("tab");
@@ -458 +436 @@
         }
 
-        // clean possibly orphaned entries in paintedTabs
-        for (Component component2 : orphaned) {
-            paintedTabs.remove(component2);
-        }
     }
 
@@ -600 +574 @@
             fireSelectedTabChange();
             requestRepaint();
+            // Repaint of the selected component is needed as only the selected
+            // component is communicated to the client. Otherwise this will be a
+            // "cached" update even though the client knows nothing about the
+            // connector
+            if (selected instanceof ComponentContainer) {
+                ((ComponentContainer) selected).requestRepaintAll();
+            } else {
+                selected.requestRepaint();
+            }
         }
     }
@@ -881 +864 @@
     }
 
-    @Override
-    public void removeListener(RepaintRequestListener listener) {
-        super.removeListener(listener);
-        if (listener instanceof CommunicationManager) {
-            // clean the paintedTabs here instead of detach to avoid subtree
-            // caching issues when detached-attached without render
-            paintedTabs.clear();
-        }
-    }
-
     /**
      * Tab meta-data for a component in a {@link TabSheet}.