Changeset cc74de9d3 in vaadin

Timestamp:

03/21/12 13:28:09 (14 months ago)

Author:

Artur Signell <artur@…>

Branches:

master, 7.0, 8a42394c6341f26066f41d3560f2419658a67a62

Children:

0ccbb6f7

Parents:

49c33ff2d

git-author:

Artur Signell <artur@…> (03/20/12 13:57:37)

git-committer:

Artur Signell <artur@…> (03/21/12 13:28:09)

Message:

Pass ManagedLayout to layout slot to avoid NPE when a child is detached
(getParent() returns null)

Location:

src/com/vaadin/terminal/gwt/client/ui

Files:

• AbstractOrderedLayoutConnector.java (modified) (1 diff)
• VGridLayout.java (modified) (6 diffs)
• layout/ComponentConnectorLayoutSlot.java (modified) (5 diffs)

src/com/vaadin/terminal/gwt/client/ui/AbstractOrderedLayoutConnector.java

@@ -242 +242 @@
                 // create a new slot.
                 slot = new ComponentConnectorLayoutSlot(getWidget()
-                        .getStylePrimaryName(), child);
+                        .getStylePrimaryName(), child, this);
             }
             layout.addOrMove(slot, currentIndex++);

src/com/vaadin/terminal/gwt/client/ui/VGridLayout.java

@@ -60 +60 @@
     }
 
-    private ComponentConnector getPaintable() {
-        return ConnectorMap.get(client).getConnector(this);
+    private GridLayoutConnector getConnector() {
+        return (GridLayoutConnector) ConnectorMap.get(client)
+                .getConnector(this);
     }
 
@@ -236 +237 @@
 
     private boolean isUndefinedHeight() {
-        return getPaintable().isUndefinedHeight();
+        return getConnector().isUndefinedHeight();
     }
 
     private boolean isUndefinedWidth() {
-        return getPaintable().isUndefinedWidth();
+        return getConnector().isUndefinedWidth();
     }
 
@@ -456 +457 @@
         public boolean hasRelativeHeight() {
             if (slot != null) {
-                return slot.getPaintable().isRelativeHeight();
+                return slot.getChild().isRelativeHeight();
             } else {
                 return true;
@@ -514 +515 @@
         protected boolean hasRelativeWidth() {
             if (slot != null) {
-                return slot.getPaintable().isRelativeWidth();
+                return slot.getChild().isRelativeWidth();
             } else {
                 return true;
@@ -552 +553 @@
             hasContent = childUidl != null;
             if (hasContent) {
-                ComponentConnector paintable = client.getPaintable(childUidl);
-
-                if (slot == null || slot.getPaintable() != paintable) {
+                ComponentConnector childConnector = client
+                        .getPaintable(childUidl);
+
+                if (slot == null || slot.getChild() != childConnector) {
                     slot = new ComponentConnectorLayoutSlot(CLASSNAME,
-                            paintable);
+                            childConnector, getConnector());
                     Element slotWrapper = slot.getWrapperElement();
                     getElement().appendChild(slotWrapper);
 
-                    Widget widget = paintable.getWidget();
+                    Widget widget = childConnector.getWidget();
                     insert(widget, slotWrapper, getWidgetCount(), false);
                     Cell oldCell = widgetToCell.put(widget, this);
@@ -569 +571 @@
                 }
 
-                paintable.updateFromUIDL(childUidl, client);
+                childConnector.updateFromUIDL(childUidl, client);
             }
         }

src/com/vaadin/terminal/gwt/client/ui/layout/ComponentConnectorLayoutSlot.java

@@ -11 +11 @@
 public class ComponentConnectorLayoutSlot extends VLayoutSlot {
 
-    final ComponentConnector paintable;
-    private LayoutManager layoutManager;
+    final ComponentConnector child;
+    final ManagedLayout layout;
 
     public ComponentConnectorLayoutSlot(String baseClassName,
-            ComponentConnector paintable) {
-        super(baseClassName, paintable.getWidget());
-        this.paintable = paintable;
-        layoutManager = paintable.getLayoutManager();
+            ComponentConnector child, ManagedLayout layout) {
+        super(baseClassName, child.getWidget());
+        this.child = child;
+        this.layout = layout;
     }
 
-    public ComponentConnector getPaintable() {
-        return paintable;
+    public ComponentConnector getChild() {
+        return child;
     }
 
@@ -28 +28 @@
     protected int getCaptionHeight() {
         VCaption caption = getCaption();
-        return caption != null ? layoutManager.getOuterHeight(caption
-                .getElement()) : 0;
+        return caption != null ? getLayoutManager().getOuterHeight(
+                caption.getElement()) : 0;
     }
 
@@ -35 +35 @@
     protected int getCaptionWidth() {
         VCaption caption = getCaption();
-        return caption != null ? layoutManager.getOuterWidth(caption
-                .getElement()) : 0;
+        return caption != null ? getLayoutManager().getOuterWidth(
+                caption.getElement()) : 0;
+    }
+
+    public LayoutManager getLayoutManager() {
+        return layout.getLayoutManager();
     }
 
@@ -43 +47 @@
         VCaption oldCaption = getCaption();
         if (oldCaption != null) {
-            layoutManager.unregisterDependency(
-                    (ManagedLayout) paintable.getParent(),
+            getLayoutManager().unregisterDependency(layout,
                     oldCaption.getElement());
         }
         super.setCaption(caption);
         if (caption != null) {
-            layoutManager
-                    .registerDependency((ManagedLayout) paintable.getParent(),
-                            caption.getElement());
+            getLayoutManager().registerDependency(
+                    (ManagedLayout) child.getParent(), caption.getElement());
         }
     }
@@ -57 +59 @@
     @Override
     public int getWidgetHeight() {
-        return layoutManager.getOuterHeight(paintable.getWidget().getElement());
+        return getLayoutManager()
+                .getOuterHeight(child.getWidget().getElement());
     }
 
     @Override
     public int getWidgetWidth() {
-        return layoutManager.getOuterWidth(paintable.getWidget().getElement());
+        return getLayoutManager().getOuterWidth(child.getWidget().getElement());
     }
 
     @Override
     public boolean isUndefinedHeight() {
-        return paintable.isUndefinedHeight();
+        return child.isUndefinedHeight();
     }
 
     @Override
     public boolean isUndefinedWidth() {
-        return paintable.isUndefinedWidth();
+        return child.isUndefinedWidth();
     }
 
     @Override
     public boolean isRelativeHeight() {
-        return paintable.isRelativeHeight();
+        return child.isRelativeHeight();
     }
 
     @Override
     public boolean isRelativeWidth() {
-        return paintable.isRelativeWidth();
+        return child.isRelativeWidth();
     }
 }