Opened 8 years ago

Last modified 3 years ago

#3351 released defect (fixed)

Sampler uses the same theme for all users

Reported by: Jouni Koivuviita Owned by: Jouni Koivuviita
Priority: blocker Milestone: Vaadin 6.1.1
Component: Sampler Version: 6.1.0
Keywords: Cc:
Depends on:
Workaround:
Verified:
Fv: no Pro Account: Mark as Priority

Description


Change history (6)

comment:1 Changed 8 years ago by Jouni Koivuviita

  • Resolution set to invalid
  • Status changed from new to closed

Seems I was a bit hasty with the ticket. The current theme is saved as a static variable, so application restarts won't affect it.

comment:2 Changed 8 years ago by Matti Tahvonen

  • Priority changed from normal to blocker
  • Resolution invalid deleted
  • Status changed from closed to reopened

Well, working as coded but to me this seems like a critical bug.

As it is static it is shared among all users. When user selects a theme it will be applied for all new windows, even for other users. Try with two browsers. The bug is live on demo.vaadin.com.

comment:3 Changed 8 years ago by Jouni Koivuviita

Nice catch, thanks Matti.

My quick assumption with the static was, that I just wanted the theme to stay the same for one user on multiple Sampler instances (e.g. several tabs open), but I guess even that sounds a bit funny now that I think about it. All windows should behave as separate instances.

comment:4 Changed 8 years ago by Artur Signell

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Summary changed from Regression: Sampler uses Runo theme by default to Sampler uses the same theme for all users

Fixed in [8826](6.1), [8827](6.2)

comment:5 Changed 4 years ago by Artur Signell

  • Fv unset

comment:6 Changed 3 years ago by Artur Signell

  • Status changed from closed to released
Note: See TracTickets for help on using tickets.