Opened 11 years ago

Last modified 3 years ago

#442 released defect (fixed)

CustomLayout relocation and bugfixes

Reported by: Joonas Lehtinen Owned by: Marc Englund
Priority: blocker Milestone: 4.0.0-rc
Component: WebTerminalAdapter Version: 4.0.0-beta2
Keywords: Cc: mauno.haukila@…
Depends on:
Workaround:
Verified:
Fv: no Pro Account: Mark as Priority

Description

Custom layouts

new CustomLayout("foo")
AJAX

  • Loads from WEB-INF/themes/teemannnimi/layout/foo.html

foo.html example

whatever stuff such as html and links to css
<customlayout>
	<img src=././mylogo.jpg />
	<div location="leftbar"> this text is also discarded </div>
	<div location="rightbar"></div>
</customlayout>
more whatever stuff

In example mylogo.jpg is loaded from WEB-INF/themes/teemannnimi/layout/mylogo.jpg

Client replaces the following cases with URL to themes layouts directory

  • '././'
  • /src=["|'][(https:|http:|/)]/i
  • /url([(https:|http:|/)]/i

Change history (6)

comment:1 Changed 11 years ago by Joonas Lehtinen

  • hours_left set to 15
  • Owner changed from Joonas Lehtinen to Marc Englund

comment:2 Changed 11 years ago by Jani Laakso

  • hours_left changed from 15 to 10

It was agreed that Marc will inspect this ticket within 4.0.0-RC timeframe, only minor testing is performed. Most notably URL "rewriting" may contain bugs, these will be fixed in maintenance releases.

comment:3 Changed 11 years ago by Jani Laakso

  • Cc mauno.haukila@… added

Mauno will test this using 4.0.0-rc1

comment:4 Changed 11 years ago by Marc Englund

  • Resolution set to fixed
  • Status changed from new to closed
  • Looks for CustomLayout in [themeBase]/layout/[style].html
  • prepends [themeBase]/layout/ to urls not starting with "/", "http:" or "https:" for attributes:
    • src=
    • codebase=
    • code=
    • background=
    • usemap=
    • lowsrc=
    • href=
  • replaces token "././" with [themeBase]/layout/
  • caches rewritten customlayout text

comment:5 Changed 4 years ago by Artur Signell

  • Fv unset

comment:6 Changed 3 years ago by Artur Signell

  • Status changed from closed to released
Note: See TracTickets for help on using tickets.